Muzosh
commented
2 years ago I'm not sure if this helps you, but you can build it yourself by cloning the repository and following this: https://github.com/web-eid/web-eid.js#development.
Closed joellimberg closed 2 years ago
Muzosh
commented
2 years ago I'm not sure if this helps you, but you can build it yourself by cloning the repository and following this: https://github.com/web-eid/web-eid.js#development.
joellimberg
commented
2 years ago Yeah, I figured out how to get the built file (it seems to be easiest to use the build artifacts, although finding the correct stable release is still not trivial).
I just think the repo should also provide usable and official distribution files to make it easier for other implementers :)
taneltm
commented
2 years ago Thanks @joellimberg for pointing it out!
The current setup is intentional:
dist/iife/web-eid.js. There could be a CI step to check for this mismatch, but there are better options.dist/iife/web-eid.js should always match the source, which might not necessarily be the latest stable version.The place to download a stable pre-built version of the library should be under https://github.com/web-eid/web-eid.js/releases. However, thanks you your comment, I now noticed that the pre-built versions are not there and that's definitely something we should fix!
joellimberg
commented
2 years ago Yep, it doesn't really matter where exactly the built files are, as long they exist and are linked from the README :)
mrts
From the readme, under Installation → Without a module system: ”Use the dist/iife build. It exposes the webeid object globally.”
The “dist/iife build” is not actually in the repo or under releases.
It would be clearer if there was a clear link to a browser-usable js file. Currently, the built files can only be found under GitHub action build artifacts (eg https://github.com/web-eid/web-eid.js/actions/runs/2058087830)