search

web-ext-experiments / logins

Webextensions experiments implementation of logins API
BSD 3-Clause "New" or "Revised" License
17 stars 12 forks source link

Result of check functions isn't returned #7

Open evilpie opened 8 years ago

evilpie commented 8 years ago

The rejection promise is never returned https://github.com/web-ext-experiments/logins/blob/master/api.js#L86, so calling the check function is basically useless. (I haven't tested this)

aswan commented 8 years ago

You're right, that code used to throw and then it got carelessly rewritten. The fix is easy but it should include tests, I'll try to get to it at some point.

bobsilverberg commented 7 years ago

Note to self: This is already fixed, along with the test, in my local m-c repo.