search

web-illinois / illinois_framework_theme

An Illinois branded Drupal theme based off of the bootstrap4 theme.
5 stars 1 forks source link

Switch to CK editor 5 #1001

Open nhjohnstone opened 1 month ago

nhjohnstone commented 1 month ago

We need to update to CK editor 5 as CK editor 4 is deprecated

github-actions[bot] commented 1 month ago

Branch nhjohnstone/issue-1001-switch-to-ck-editor-5 created!

nhjohnstone commented 1 month ago

ran into some issues that are related to Drupal 10.3 update (or 10.2):

before switching to ckeditor 5, had to remove "class" and "start" from the tags in allowed html tags

Screenshot 2024-07-11 at 2 56 04 PM

https://www.drupal.org/project/drupal/issues/3410100

Linkit Media Library button is not working, due to a Drupal 10.3 change https://www.drupal.org/project/drupal/issues/3446026

I added the patch so we could see the button, but we might want to remove it if this doesn't get fixed. Linkit Media Library is not being maintained

nhjohnstone commented 1 month ago

testing process

ddev composer require web-illinois/illinois_framework_profile:dev-43-update-to-ckeditor5 -W

had to delete vendor folder and composer install to get patches to apply

there are no DB updates

enable ckeditor 5 in drupal UI

drush config-distro-update -y

imports the editor config changes

compile sass files

sass --watch scss/style.scss:css/style.css scss/ck5style.scss:css/ck5style.css