web-illinois / illinois_framework_theme

An Illinois branded Drupal theme based off of the bootstrap4 theme.
6 stars 1 forks source link

Icon row paragraph #149

Closed magjarvis closed 3 years ago

magjarvis commented 3 years ago
github-actions[bot] commented 3 years ago

Branch feature/magjarvis/issue-149-icon-row-paragraph created!

mwllr commented 3 years ago

Add field for spacing before paragraph: no, small, med, lg, xlg.. See Call to Action Narrow for example already added.

mwllr commented 3 years ago

Screen Shot 2021-07-09 at 3 28 25 PM

mwllr commented 3 years ago
mwllr commented 3 years ago

Need to see white on gray, then look at link of text color on gray background. Is the med blue okay? do we want something different? Screen Shot 2021-07-09 at 3 43 58 PM

wrg20 commented 3 years ago

Wrapping of icons can be done by changing these rules on these classes.

image

image

lizshalley commented 3 years ago

add FAQ icon: https://toolkit.marketing.web.illinois.edu/icons/ Screen Shot 2021-07-12 at 11 05 02 AM

magjarvis commented 3 years ago

icon-wrap this is how 7 icons are wrapping if we add flex-wrap, 6 icons wrap to three rows of two. is that what we still want to do? Or should we limit the number of icons per paragraph?

lizshalley commented 3 years ago

my vote would be to limit to 5, @mwllr?

magjarvis commented 3 years ago

White text on gray background fails all accessibility checks for contrast. We could do illini blue callout text? Or Altgeld orange passes AA standards for the callout text if we want to use that. icon-blue

magjarvis commented 3 years ago

icons-altgeld Altgeld callout text

magjarvis commented 3 years ago

my vote would be to limit to 5, @mwllr?

icon-2rows

So, here is two separate icon row paragraphs on top of each other. top row 5, bottom row 2. With this option you also have the additional option of adding spacing between the two rows

magjarvis commented 3 years ago

Obviously, it would look better to do 4 on top of 3, but it would be up to the user, so we might end up with something like the above

lizshalley commented 3 years ago

I was thinking 5 max... as in no more than 5 total items per paragraph type. that's probably a design group or @mwllr decision.

mwllr commented 3 years ago
mwllr commented 3 years ago

@magjarvis - ready for you to work some magic!

wrg20 commented 3 years ago

Add switch / case, for icon row classes and flex-box.

trubach commented 3 years ago

@wrg20, @mwllr - I just merged #421 from Maggie. Can you use the sandbox site to verify everything is OK and close this issue if it is? The sandbox won't reflect these changes until tomorrow (9/25). Otherwise, maybe add some more tasks to the list of checkboxes above.

mwllr commented 3 years ago

Awesome job Maggie! I believe we are good to go!