search

web-illinois / illinois_framework_theme

An Illinois branded Drupal theme based off of the bootstrap4 theme.
6 stars 1 forks source link

add visible-hidden text to social media icons in footer #822

Closed Detzner closed 2 years ago

Detzner commented 2 years ago

in templates > region > region—footer.html.twig, add visible-hidden text label to social media icons in footer, lines 59 - 71 (Instagram), have to insert text because icons are font-based, not images where you could put an alt tag

github-actions[bot] commented 2 years ago

Branch wrg20/issue-822-add-visible-hidden-text-to-social-media-icons-in-footer created!

wrg20 commented 2 years ago

Per the toolkit...https://cdn.brand.illinois.edu/toolkit/2.10/examples/components/footer/default/index.html it appears that the text is within the anchor tag for each social media icon.

wrg20 commented 2 years ago

@Detzner - please review the merge #852.

Detzner commented 2 years ago

Hi Bill—

I was off today, just back from out of town, but will look at this first thing tomorrow.

Dick

From: William Gutierrez @.> Date: Monday, September 19, 2022 at 12:49 PM To: web-illinois/illinois_framework_theme @.> Cc: Detzner, Richard @.>, Mention @.> Subject: Re: [web-illinois/illinois_framework_theme] add visible-hidden text to social media icons in footer (Issue #822)

@Detznerhttps://urldefense.com/v3/__https:/github.com/Detzner__;!!DZ3fjg!4XwWGK0OKZOMn8RDnBN8yq7kV3XLASD5-VmMBXpiwoPowNYxvpI-389E2qbGn6s7t5XT20xi3sYtaUytyghGdYc1F-4$ - please review the merge #852https://urldefense.com/v3/__https:/github.com/web-illinois/illinois_framework_theme/pull/852__;!!DZ3fjg!4XwWGK0OKZOMn8RDnBN8yq7kV3XLASD5-VmMBXpiwoPowNYxvpI-389E2qbGn6s7t5XT20xi3sYtaUytyghGVBCuC78$.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/web-illinois/illinois_framework_theme/issues/822*issuecomment-1251346256__;Iw!!DZ3fjg!4XwWGK0OKZOMn8RDnBN8yq7kV3XLASD5-VmMBXpiwoPowNYxvpI-389E2qbGn6s7t5XT20xi3sYtaUytyghGNk-a5iE$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AL3V5AIYTLRBSS2GHRSMQADV7CRTPANCNFSM56ZWVZWQ__;!!DZ3fjg!4XwWGK0OKZOMn8RDnBN8yq7kV3XLASD5-VmMBXpiwoPowNYxvpI-389E2qbGn6s7t5XT20xi3sYtaUytyghG1fgnyng$. You are receiving this because you were mentioned.Message ID: @.***>

wrg20 commented 2 years ago

Per Teams conversation. I will add the markup @Detzner - Thank you! I'll let you know when it's ready to look at again here shortly.

mwllr commented 2 years ago

@Detzner - can you verify this is fixed? if so, close with a comment.

Detzner commented 2 years ago

Yes, this is fixed. Thanks!