search

web-illinois / toolkit

This library provides styles and web components for creating branded UIUC websites.
18 stars 7 forks source link

Site title doesn't link/hover on header - compact #79

Closed mwllr closed 3 years ago

mwllr commented 3 years ago

https://cdn.brand.illinois.edu/toolkit/2.0/examples/components/header/default/index.html

melissawaller78 commented 3 years ago

well. anytime there is only the primary site title, when 2 are listed, they both link....

bryanjonker-illinois commented 3 years ago

It is built so the site title can be a link or not.

In https://cdn.brand.illinois.edu/toolkit/2.0/examples/components/header/default/index.html, it is implemented without a link:

        <il-unit-wordmark>
            <h1>College of Agricultural, Consumer & Environmental Sciences</h1>
        </il-unit-wordmark>

In the multiple version, it is implemented with links:

        <il-unit-wordmark>
            <p class="il-primary-unit"><a href="/">College of Education </a></p>
            <h1><a href="/">Council on Teacher Education</a></h1>
        </il-unit-wordmark>
mwllr commented 3 years ago

Site title must always link to the home page! REQUIRED. Secondary site (smaller above primary) title doesn't have to link. Add to example headers. (need by ITPF)

bryanjonker-illinois commented 3 years ago

We'll put a note in the usage guide, but this is a part of the usage, not hardcoded here.