setExternal 配置未生效

yuanlf commented 2 years ago

Describe the bug

1）基座项目设置了共享依赖 Garfish.setExternal({ react: React, "react-dom": ReactDOM, "react-router-dom": ReactRouterDom, }); 2）子项目 webpack 中配置了 externals externals: { react: "React", "react-dom": "ReactDOM", "react-router-dom": "ReactRouterDOM", }, 3）加载子项目时，会提示如下错误 [Garfish warning]: Package "ReactDOM" is not found [Garfish warning]: Package "React" is not found

Reproduction

https://www.garfishjs.org/

Used Package Manager

npm

System Info

System:
    OS: macOS 12.4
    CPU: (8) x64 Apple M1 Pro
    Memory: 17.45 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 12.22.12 - /usr/local/bin/node
    Yarn: 1.22.18 - /usr/local/bin/yarn
    npm: 8.6.0 - /usr/local/bin/npm
  Browsers:
    Safari: 15.5

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Garfish issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

zhoushaw commented 2 years ago

子应用 external 改成：

externals: {
react: "react",
"react-dom": "react-dom",
"react-router-dom": "react-router-dom",
},