Closed Asuka109 closed 1 month ago
Latest commit: 6440c45b2f5f28db93637cf79d9b8a687639695d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
It seems that most of the code is same as before, and now it has become very clear~
[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...
Commits
Files that changed from the base of the PR and between 15a090c4f3518693eb5b64d07fbd114bd954b481 and 78d9a71a44083208f9f2d6a6603da2859b86e6ad.Files ignored due to path filters (1)
* `pnpm-lock.yaml` is excluded by `!**/pnpm-lock.yaml`Files selected for processing (10)
* packages/devtools/plugin/package.json (3 hunks) * packages/devtools/plugin/src/cli.ts (1 hunks) * packages/devtools/plugin/src/plugins/debug.ts (1 hunks) * packages/devtools/plugin/src/plugins/html.ts (1 hunks) * packages/devtools/plugin/src/plugins/http.ts (1 hunks) * packages/devtools/plugin/src/plugins/rpc.ts (1 hunks) * packages/devtools/plugin/src/plugins/service-worker.ts (1 hunks) * packages/devtools/plugin/src/plugins/state.ts (1 hunks) * packages/devtools/plugin/src/plugins/watcher.ts (1 hunks) * packages/devtools/plugin/src/types/common.ts (2 hunks)______________________________ < torvalds@linux:~$ git review > ------------------------------ \ \ \ \ /\ ( ) .( o ).
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary
Develop a hook system for the devtools plugin to unify the lifecycle system across the framework, builder, and bundler. This will also benefit sequence and maintainability.
The majority of source code in
packages/devtools/plugin/src/plugins/*
is extracted from:packages/devtools/plugin/src/cli.ts
packages/devtools/plugin/src/rpc/index.ts
Reviewers can check out those files from the main branch for better comparing and readability.
You can check out revisions from the main branch and view them in VSCode by:
git show main:packages/devtools/plugin/src/cli.ts | code -
git show main:packages/devtools/plugin/src/rpc/index.ts | code -
Related Links
Checklist
pnpm run change
.