search

web-infra-dev / modern.js

Modern.js is a web engineering system, including a web framework and a npm package solution.
https://modernjs.dev/en/
MIT License
4.4k stars 367 forks source link

[Feature]: Plugin for shadcn/ui #5851

Closed raolak closed 1 week ago

raolak commented 3 months ago

What problem does this feature solve?

shadcn/ui is a popular Design system and providers out of the box components,. It would be great if we can add shadcn-ui@latest init support which can provides tooling for initial setup and managing components

What does the proposed API look like?

support shadcn-ui@latest init

yf-yang commented 2 months ago

Why not directly add it as a dependency? shadcn doesn't involve any compile time stuff, so I suspect if it should be added. BTW I am currently using it with modern.js fluently.

raolak commented 2 months ago

Hi Yang

This is sorted.! It's working for me. I can have a document for this.

_lnr

On Tue, Jul 16, 2024 at 10:13 AM yf-yang @.***> wrote:

Why not directly add it as a dependency? shadcn doesn't involve any compile time stuff, so I suspect if it should be added. BTW I am currently using it with modern.js fluently.

— Reply to this email directly, view it on GitHub https://github.com/web-infra-dev/modern.js/issues/5851#issuecomment-2230009129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGPZOMRMO2BLFZRA36ZUM3ZMSQHRAVCNFSM6AAAAABJRNPGC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGAYDSMJSHE . You are receiving this because you authored the thread.Message ID: @.***>

raolak commented 2 months ago

Also

In with pnpm run dev , I am able to module federation working. But I am not sure how to get it working for production setup. I am planning to containerise and deploy in k8s.

Any documentation or help is really appreciated !

Thank you lnr

On Tue, Jul 16, 2024 at 11:24 AM Lakshminarayan Rao < @.***> wrote:

Hi Yang

This is sorted.! It's working for me. I can have a document for this.

_lnr

On Tue, Jul 16, 2024 at 10:13 AM yf-yang @.***> wrote:

Why not directly add it as a dependency? shadcn doesn't involve any compile time stuff, so I suspect if it should be added. BTW I am currently using it with modern.js fluently.

— Reply to this email directly, view it on GitHub https://github.com/web-infra-dev/modern.js/issues/5851#issuecomment-2230009129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGPZOMRMO2BLFZRA36ZUM3ZMSQHRAVCNFSM6AAAAABJRNPGC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGAYDSMJSHE . You are receiving this because you authored the thread.Message ID: @.***>

zllkjc commented 1 week ago

I will add some docs for module federation in modern.js website. now you can refer to module federation website to get some info