[Bug]: The CommonJS bundle can not be consumed by `import()` in Node.js

[chenjiahan]

Version

System: OS: macOS 14.6.1 CPU: (16) arm64 Apple M3 Max Memory: 8.00 GB / 64.00 GB Shell: 5.9 - /bin/zsh Browsers: Chrome: 130.0.6723.71 Safari: 17.6 npmPackages: @rslib/core: ^0.0.15 => 0.0.15

Details

• Input:

export function example(): string {
  return 'hello world';
}

• Config:

import { defineConfig } from '@rslib/core';

export default defineConfig({
  lib: [
    {
      format: 'cjs',
      syntax: 'es2021',
    },
  ],
  output: { target: 'node' },
});

• Create a test.mjs file to import() the dist bundle:

async function main() {
    const { example } = await import('./dist/index.cjs');
    console.log(example);
    // tsup: got "[Function: example]"
    // Rslib: got "undefined"
}
main();

Reproduce link

https://github.com/chenjiahan/rslib-repro-cjs-export

Reproduce Steps

Rslib:

• pnpm run build
• node ./test.mjs

tsup:

• npx tsup
• node ./test.mjs

[chenjiahan]

This is required for ESM import in node:

// Annotate the CommonJS export names for ESM import in node:
0 && (module.exports = {
  example
});

Ref:

• https://github.com/evanw/esbuild/commit/20fc8a893591d02da4a1c9e460e63057f8451d9b
• https://github.com/evanw/esbuild/commit/b86e58128d9c9281c92c3bca3b2f1a0a5131eaf8

[fi3ework]

I think we're aligned with esbuild's behavior?

https://esbuild.github.io/try/#YgAwLjI0LjAALS1idW5kbGUgLS1mb3JtYXQ9Y2pzAGUAZW50cnkudHMAZXhwb3J0IGZ1bmN0aW9uIGV4YW1wbGUoKTogc3RyaW5nIHsKICByZXR1cm4gJ2hlbGxvIHdvcmxkJzsKfQo

async function main() {
  const thing = await import('./dist/index.cjs')
  console.log(thing, thing.example)
}

Checked by manually copy to the dist.

esbuild:

rslib:

[chenjiahan]

@fi3ework --platform=node is required for esbuild