Builtin progress bar is broken when using multi compiler

chenjiahan commented 1 year ago

System Info

System: OS: macOS 13.5.2 CPU: (10) arm64 Apple M1 Pro Memory: 375.17 MB / 32.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 16.18.0 - ~/Library/Caches/fnm_multishells/41106_1695025348387/bin/node npm: 8.19.2 - ~/Library/Caches/fnm_multishells/41106_1695025348387/bin/npm Browsers: Chrome: 116.0.5845.187 Safari: 16.6 npmPackages: @rspack/cli: workspace:* => 0.3.4

Details

When there are multiple compilers, the builtin progress bar can not render as expected. The two bars overlap instead of being rendered separately:

Reproduce link

https://github.com/web-infra-dev/rspack/tree/main/examples/basic

Reproduce Steps

cd examples/basic
add following configs:

/** @type {import('@rspack/cli').Configuration} */

module.exports = [
  {
    name: "Client",
    context: __dirname,
    mode: "development",
    entry: {
      main: "./src/index.js"
    }
  },
  {
    name: "Server",
    target: "node",
    context: __dirname,
    mode: "development",
    entry: {
      main: "./src/index.js"
    }
  }
];

pnpm run dev

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

chenjiahan commented 9 months ago

bump

stale[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

chenjiahan commented 7 months ago

bump

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

chenjiahan commented 5 months ago

bump

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

hardfist commented 2 months ago

the current hooks seems enough for a progressbar implementation it's just the current progress bar implementation maybe too complex and calls too much hook

web-infra-dev / rspack