web-infra-dev / rspack

The fast Rust-based web bundler with webpack-compatible API 🦀️
https://rspack.dev
MIT License
9.34k stars 543 forks source link

Some CSS is missing after upgrading to Rspack v0.4.4 #5107

Closed chenjiahan closed 9 months ago

chenjiahan commented 9 months ago

System Info

@rspack/core v0.4.4

System: OS: macOS 14.0 CPU: (10) arm64 Apple M1 Pro Memory: 229.75 MB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 18.12.1 - ~/Library/Caches/fnm_multishells/39265_1702908249200/bin/node npm: 8.19.2 - ~/Library/Caches/fnm_multishells/39265_1702908249200/bin/npm pnpm: 8.8.0 - ~/Library/Caches/fnm_multishells/39265_1702908249200/bin/pnpm bun: 0.1.2 - ~/.bun/bin/bun Browsers: Chrome: 120.0.6099.129 Safari: 17.0

Details

I upgraded the rspack from v0.4.3 to v0.4.4 on the Vant website, then I noticed that some CSS were missing:

image

image

Reproduce link

https://github.com/youzan/vant/tree/rspack_repro_1223

Reproduce Steps

  1. git clone git@github.com:youzan/vant.git --branch rspack_repro_1223
  2. pnpm i
  3. pnpm dev
  4. open http://localhost:8080/mobile#/en-US/button
  5. Inspect the demo-button-row element:

image

You can override @rspack/core in the root package.json to v0.4.3 to compare the build results.

image

I have tried to provide a minimal reproduction, but it is hard to reproduce this issue in the demo project.

bvanjoi commented 9 months ago

I've noticed that this issue can't be reproduced in the latest commit:

image

chenjiahan commented 9 months ago

@bvanjoi because I have manually reverted the Rspack version...

https://github.com/youzan/vant/pull/12525

bvanjoi commented 9 months ago

What I meant was the latest commit of rspack: 0b9a919a2001877acd0cd54ac28b8f6eb72b37d9

chenjiahan commented 9 months ago

@bvanjoi haha, good news 👍

bvanjoi commented 9 months ago

Closing this as @rspack/core@0.4.5 functions as expected