web-infra-dev / rspack

The fast Rust-based web bundler with webpack-compatible API 🦀️
https://rspack.dev
MIT License
9.34k stars 543 forks source link

[Bug]: HtmlPlugin conflicts with EslintPlugin options "threads" #5771

Closed liangyuetian closed 1 month ago

liangyuetian commented 7 months ago

System Info

System: OS: macOS 14.2.1 CPU: (8) arm64 Apple M1 Pro Memory: 62.55 MB / 16.00 GB Shell: 5.9 - /bin/zsh npmPackages: @rspack/cli: ^0.5.4 => 0.5.4 @rspack/core: ^0.5.4 => 0.5.4

Details

HtmlPlugin conflicts with the threads options of EslintPlugin

image

Reproduce link

https://github.com/liangyuetian/rsbuild-hmr-slow-demo/blob/htmlPlugin-eslintPlugin/rsbuild.config.ts#L41

Reproduce Steps

  1. pnpm install
  2. npm run dev
LingyuCoder commented 7 months ago

I can't understand what exactly the "conflict" means. Please describe your expected behavior and the problems you encounter in more detail.

liangyuetian commented 7 months ago

I can't understand what exactly the "conflict" means. Please describe your expected behavior and the problems you encounter in more detail.

sorry,I didn't describe it clearly

in htmlPlugin, it is not equal to false and EslintPlugin options When threads coexist, the second compilation will get stuck,as shown in the above figure

LingyuCoder commented 7 months ago

seems that there is some bug in jest-worker which used in eslint-webpack-plugin. The javascript main thread keep running in this line https://github.com/webpack-contrib/eslint-webpack-plugin/blob/master/src/getESLint.js#L73, but the lintFiles in worker.js does not been called. Perhaps you can report this to jest-worker or eslint-webpack-plugin for help.

chenjiahan commented 7 months ago

does webpack has this issue?

LingyuCoder commented 7 months ago

does webpack has this issue?

I meet the same issue while using webpack-provider

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

hardfist commented 1 month ago

closed since it seems not a rspack bug, feel free to open if you have further question