web-infra-dev / rspack

The fast Rust-based web bundler with webpack-compatible API 🦀️
https://rspack.dev
MIT License
10.12k stars 575 forks source link

fix(incremental): disappeared chunk panic in chunks render #8492

Closed ahabhgk closed 4 days ago

ahabhgk commented 5 days ago

Summary

fix #8480

In the first compilation, splitChunks will split some chunks into multiple chunks, and we record the chunk render results for those chunks, but these split out chunks will be not reused in the second compilation (splitChunks not support incremental), so we need to cleanup those chunks' render results

Checklist

netlify[bot] commented 5 days ago

Deploy Preview for rspack canceled.

Name Link
Latest commit ee2703c50af07f3aa80f9a8351a75e96e2afe0d9
Latest deploy log https://app.netlify.com/sites/rspack/deploys/673dd473859538000951e676
codspeed-hq[bot] commented 5 days ago

CodSpeed Performance Report

Merging #8492 will not alter performance

Comparing fix-chunk-level-inc-panic (ee2703c) with main (0891a65)

Summary

✅ 1 untouched benchmarks