web-infra-dev / rspress

🦀💨 A fast Rspack-based static site generator.
https://rspress.dev
MIT License
1.19k stars 108 forks source link

feat: support extra head tags #1145

Closed toteto closed 2 weeks ago

toteto commented 3 weeks ago

Summary

This PR adds support for extra head tags per page via Frontmatter config.

Related Issue

1121

Checklist

netlify[bot] commented 3 weeks ago

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
Latest commit 087d8758bbf18d043c9ed76af79859ed56b5bd09
Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/666874887e4da300088b30a5
Deploy Preview https://deploy-preview-1145--aquamarine-blini-95325f.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 87 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Timeless0911 commented 3 weeks ago

Thxs, can you add a seperate new fixture for this feature instead?

toteto commented 3 weeks ago

Thxs, can you add a seperate new fixture for this feature instead?

Done in 598cdc9

toteto commented 2 weeks ago

Made changes as discussed in #1121

@Timeless0911 please re-review

toteto commented 2 weeks ago

@Timeless0911 please also consider the extension to this PR #1168

Timeless0911 commented 2 weeks ago

This PR looks like it can be closed now since #1168

toteto commented 2 weeks ago

This PR looks like it can be closed now since #1168

Sounds good, only created it as separate PR to allow the one being approved and merged without the other in case it doesn't fit into the vision for Rspress.

Feel free to close this PR if not needed.