web-infra-dev / rspress

🦀💨 A fast Rspack-based static site generator.
https://rspress.dev
MIT License
1.19k stars 108 forks source link

feat: support extra head tags, extension to #1145 #1168

Closed toteto closed 2 weeks ago

toteto commented 2 weeks ago

Summary

This PR is extension to #1145 to simplify the approval/merge process.

The change is that it introduces additional types to the head config attribute. This addition enables better per-page headers, in a sense plugin header support.

The immediate benefit i see in addition to #1145 is less duplication of tags that are to be only for a subset of the pages.

Related Issue

1145

Checklist

netlify[bot] commented 2 weeks ago

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
Latest commit 4a6a21e010cb87d684a400c487db4b44293ee0c7
Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/666967c381392500088e6dd3
Deploy Preview https://deploy-preview-1168--aquamarine-blini-95325f.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 91 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Timeless0911 commented 2 weeks ago

It seems the lockfile should be update to pass CI, you can rebase main branch and update it.

Timeless0911 commented 2 weeks ago

LGTM, I will translate the document into Chinese after this PR merged.

Timeless0911 commented 2 weeks ago

Thanks~

toteto commented 2 weeks ago

Thanks~

Thanks for getting support while doing this PR, much appreciate it