search

web-infra-dev / rspress

🦀💨 A fast Rspack-based static site generator.
https://rspress.dev
MIT License
1.21k stars 107 forks source link

[Bug]: Changing language on 404 page does nothing #995

Closed jbroma closed 2 months ago

jbroma commented 2 months ago

Details

When on 404 page, changing language does nothing and only appends new lang to the URL. Similar thing happens when using multiVersion and changing versions while on 404 page.

The question here is: what should be the desired behaviour?

Reproduce link

https://rspress.dev/404 (or any non-existent route)

Reproduce Steps

  1. Go to the 404 page on rspress.dev
  2. Change language
  3. Observe 'zh' being added to the URL indefinetly, after few times it looks like this:
image
Timeless0911 commented 2 months ago

The desired behavior is that the 404 page does not have multi-version and language switching, and there should be some bugs now when we switching.