web-pal / chronos-timetracker

Desktop client for JIRA. Track time, upload worklogs without a hassle.
https://chronos.web-pal.com
MIT License
299 stars 66 forks source link

Cannot mention some users in comments #169

Open Bcow7 opened 5 years ago

Bcow7 commented 5 years ago

Expected Behavior

Be able to mention some users (with @...) in new comments in issues

Actual Behavior

"@" character doesn't display any users list

Steps to Reproduce the Problem

  1. Open an issue in right panel
  2. Click on "Comments" tab
  3. Type a new comment and try to mention a user of the project

Specifications

yomn61 commented 5 years ago

Hello there, I am a new contributor and would like to work on this issue. Where should I start?

VladimirPal commented 5 years ago

@yomn61 Hi! Read contributing document. https://github.com/web-pal/chronos-timetracker/blob/develop/CONTRIBUTING.md

So you need to check how user mention works in jira. They show a dropdown when you type @ sign. You need to do a similar with atlaskit dropdown https://atlaskit.atlassian.com/packages/core/dropdown-menu/example/with-anything-as-a-trigger

I've prepared API request for this feature, which can be called like this: https://github.com/web-pal/chronos-timetracker/blob/develop/app/renderer/api/jiraApi/index.js#L11

    const users = yield eff.call(
      jiraApi.searchForMentionUsers,
      {
        params: {
          query: 'searchKey',
          issueKey: 'issueKey',
          projectKey: 'projectKey',
        },
      },
    );

Comment component here https://github.com/web-pal/chronos-timetracker/blob/develop/app/renderer/containers/IssueView/IssueComments/IssueComments.jsx

It will not be easy if you never worked with our technology stack. Thank you for the try in advance.

yomn61 commented 5 years ago

I am still working on this issue and have been trying to implement this feature as you said, however, I noticed the Issue Description has the functionality we're looking for but I wasn't able to find where that call was made. Do you know where that function occurs and if it would be feasible to reuse that code?

Thank you.

VladimirPal commented 5 years ago

@yomn61 Hi! I appreciate you try to implement the feature. Maybe you could develop it with some mock data? Just hardcode the list of users which can be mentioned, when it will be done, i'll connect api request to the component.

parvezalisha commented 5 years ago

@VladimirPal Is this still being worked on? If not, can i pick it up? I am very familiar with this technology stack.

VladimirPal commented 5 years ago

@parvezalisha Of course, go-ahead