web-pal / chronos-timetracker

Desktop client for JIRA. Track time, upload worklogs without a hassle.
https://chronos.web-pal.com
MIT License
299 stars 66 forks source link

Replacing clear plugin with reset plugin #65

Closed jamesplease closed 6 years ago

jamesplease commented 6 years ago

A quick glance suggests that the “clear” plugins you have defined could possibly be replaced with the reset plugin.

If you tried that out, and some feature was missing, then perhaps that missing feature could be backported into the core lib to reduce the amount of app code you need to write 🙂

Also, in the next release (2.5), you will be able to set the resource meta using built-in tools, so the meta plugin that you have can also be removed from the app :v:

Thanks for reading!

VladimirPal commented 6 years ago

@jmeas Thanks, i'll try to use reset plugin, also will check new release.

VladimirPal commented 6 years ago

Unfortunately we can't use this plugins, because we have indexedList plugin, since we need indexed list for react-virtualized.