search

web-platform-tests / interop-accessibility

Accessibility Testing for WPT
https://wpt.fyi/results/?q=label%3Aaccessibility
38 stars 5 forks source link

Can we add file-level suggested reviewers in wpt-metadata? #104

Open cookiecrook opened 6 months ago

cookiecrook commented 6 months ago

This recent merge is a good change, but modified the Interop 2024 deltas unexpectedly, after the test list had been agreed upon. I think the same will happen in other test files this year.

The reason I didn't notice is because the PR checks auto-assigned DOM reviewers (associated with the directory) but not accessibility reviewers that might have spotted that would add more work for Interop 2024.

This issue is a task tracker to see if we can add test-level (instead of dir-level) suggested reviewers in the META.yml.

zcorpan commented 6 months ago

Related: https://github.com/web-platform-tests/interop/issues/346

keithamus commented 1 month ago

Expanding the CODEOWNERS file to add an a11y team may help. Any handle or team listed in the CODEOWNERS file matching a file pattern will be requested as a reviewer for any PR.

You can read more about code owners here: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

So for example adding this to the codeowners would mean any file altered which contains aria in the name would automatically register @cookiecrook as a reviewer:

/**aria* @cookiecrook

It can be helpful to set up teams which can then also be assigned as codeowners, e.g. having lines like /core-aam @web-platform-tests/core-aam-reviewers could be helpful here.