web-platform-tests / interop

web-platform-tests Interop project
https://wpt.fyi/interop
280 stars 28 forks source link

font-size-adjust #541

Closed firefoxic closed 7 months ago

firefoxic commented 11 months ago

Description

The font-size-adjust property allows you to make different fonts the same visual size. This is useful when replacing a local font with a custom font, or when different fonts are adjacent on the same line.

Specification

https://www.w3.org/TR/css-fonts-3/#font-size-adjust-prop

Open Issues

No response

Tests

https://wpt.fyi/results/css/css-fonts?label=experimental&label=master&aligned=&q=font-size-adjust

Current Implementations

Standards Positions

No response

Browser bug reports

https://crbug.com/451346 https://crbug.com/1219875

Developer discussions

No response

Polls & Surveys

No response

Existing Usage

No response

Workarounds

No response

Accessibility Impact

No response

Privacy Impact

No response

Other

https://developer.mozilla.org/en-US/docs/Web/CSS/font-size-adjust https://caniuse.com/font-size-adjust

jensimmons commented 11 months ago

This would be a great thing to add to Interop 2024. We should be sure to include all three parts:

Screenshot 2023-10-05 at 6 38 06 PM

The tests are not working correctly if Chrome has not yet added support for font-size-adjust, but passes 88.8% of the tests.... so we need to take a look at the tests.

dbaron commented 11 months ago

You should see drastically different test results between: https://wpt.fyi/results/css/css-fonts?label=experimental&label=master&q=font-size-adjust (which tests Chrome dev channel, with --enable-experimental-web-platform-features) and https://wpt.fyi/results/css/css-fonts?label=master&label=stable&q=font-size-adjust (which tests Chrome stable channel).

jensimmons commented 11 months ago

Ah, that makes sense. Great news.

That means the current experiment scores are: Chrome Dev: 88.8% Firefox Nightly: 100% Safari Technology Preview: 98.5%

There's a chance the scores will be too high to make sense to consider for Interop 2024 — that we have interop before the year starts.

firefoxic commented 11 months ago

I am skeptical about this. After all, Chrome has had this property behind the flag for years. And I have no hope at all that this will change. My only hope is Interop ❤️

kojiishi commented 11 months ago

This is a recent progress, please see crbug.com/1219875. @shivamidow @drott

shivamidow commented 11 months ago

I have pushed font-size-adjust to both Blink and WebKit this year. All necessary pieces are in the review pipeline, so Blink and WebKit will hit 100% soon.

Blink:

WebKit:

firefoxic commented 11 months ago

Is there similarly positive news regarding size-adjust #542 ?

drott commented 10 months ago

In the process, we should try to get a resolution on https://github.com/w3c/csswg-drafts/issues/8967 CC @svgeesus

jensimmons commented 9 months ago

The proposed test set includes font-size-adjust-metrics-override.html — which requires support for ascent-override / descent-override, a feature WebKit does not yet support. We'd like this test to not be included, since it's an 'off topic dependency'.

zcorpan commented 7 months ago

Thank you for proposing font-size-adjust for inclusion in Interop 2024.

We are pleased to let you know that this proposal was accepted as part of the font-size-adjust focus area. You can follow the progress of this focus area on the Interop 2024 dashboard.

For an overview of our process, see the proposal selection. Thank you for contributing to Interop 2024!

Posted on behalf of the Interop team.