search

web-platform-tests / interop

web-platform-tests Interop project
https://wpt.fyi/interop
296 stars 28 forks source link

Add more tests (related to transition-behavior) into "@starting-style & transition-behavior" focus area #639

Closed BorisChiou closed 6 months ago

BorisChiou commented 7 months ago

Test List

https://wpt.fyi/results/css/css-transitions/transition-behavior.html?label=experimental&label=master&aligned https://wpt.fyi/results/css/css-masking/clip-path/animations/clip-path-interpolation-discrete.html?label=experimental&label=master&aligned https://wpt.fyi/results/css/motion/animation/offset-path-interpolation-007.html?label=experimental&label=master&aligned

Rationale

I renamed css-transitions/all-with-discrete.tentative.html as css-transitions/transition-behaivor.html because transtion-property: all is not a special case now and the spec uses transition-behavior to handle discrete transition cases, in this PR. I added some more sub-tests in transition-behaivor.html as well. For now, Gecko and WebKit passed all sub-tests.

I also added clip-path-interpolation-discrete.html and offset-path-interpolation-007.html (in this PR) to make sure we create the discrete transitions if the animation values fall back to discrete. For now, Gecko and WebKit passed all sub-tests.

Therefore, perhaps it's worth to add these three tests into @starting-style & transition-behavior focus area because the current test meta only check the parsing and serialization of transition-behavior. It's not enough obviously.

BorisChiou commented 7 months ago

cc @nt1m @josepharhar

nt1m commented 7 months ago

Looks fine, thanks for adding more test coverage! Would be nice to fix the typo in the test name "transition-behaivor".

BorisChiou commented 7 months ago

Oh right. I will upload a PR to fix it.

BorisChiou commented 7 months ago

I uploaded a Gecko patch, https://phabricator.services.mozilla.com/D202666, to fix this typo.

Updated: https://github.com/web-platform-tests/wpt/pull/44772

foolip commented 7 months ago

@lilles can you review?

josepharhar commented 7 months ago

This seems fine to me

BorisChiou commented 7 months ago

The fix of the typo was landed, so I updated the test list with the correct test file name, for the 1st test file, i.e. transition-behavior.html.

foolip commented 6 months ago

We have review from someone working on each of Chromium, Gecko and WebKit now. @BorisChiou these should all be labeled with interop-2024-transition-behavior, right? I ask because two of the tests don't include the string "transition-behavior" but I didn't follow included scripts and whatnot.

BorisChiou commented 6 months ago

Yes. Two of the tests use behavior: 'allow-discrete', which sets transition-behavior in interpolation framework.

foolip commented 6 months ago

I have labeled the three tests here: https://github.com/web-platform-tests/wpt-metadata/pull/5789 https://github.com/web-platform-tests/wpt-metadata/pull/5790 https://github.com/web-platform-tests/wpt-metadata/pull/5791