search

web-platform-tests / interop

web-platform-tests Interop project
https://wpt.fyi/interop
296 stars 28 forks source link

Remove or fix img label computation tests #648

Closed dandclark closed 6 months ago

dandclark commented 6 months ago

Test List

In accname/name/comp_label.html:

Rationale

These tests are meant to exercise the case in https://w3c.github.io/accname/#computation-steps where if the aria-label is undefined in step 2D, then the aria-label is not used and instead in step 2E the Host Language Label is used (alt or title in this case). However, the tests are setting the attribute to the literal string "undefined", so it's by design that this value is used.

Additionally the last two tests suggest that the elements should have a title set but that is missing.

All engines currently fail these tests.

There is already a PR to remove these, although there's been no activity for a month: https://github.com/web-platform-tests/wpt/pull/44600

I think either the tests should be corrected, or the PR to remove them should be landed.

zcorpan commented 6 months ago

+1 to land https://github.com/web-platform-tests/wpt/pull/44600

cc @cookiecrook

cookiecrook commented 6 months ago

Yes, thanks. Merged.