search

web-platform-tests / interop

web-platform-tests Interop project
273 stars 28 forks source link

Add one subtest into css/css-properties-values-api/at-property-animation.html, for custom properties focus area #662

Closed BorisChiou closed 1 month ago

BorisChiou commented 2 months ago

Test List

Add a subtest into https://wpt.fyi/results/css/css-properties-values-api/at-property-animation.html?label=experimental&label=master&aligned

The change is in https://phabricator.services.mozilla.com/D210589#change-L2S1zuPHNYWc

Rationale

I just fixed an issue on Gecko when we reverse an ongoing transition to its initial state (Bug 1888317), and I am trying to add a subtest for it. It seems it may let other browsers get failed on this subtest (e.g. WebKit, per this comment), so I filed this issue for the approval before I land my patch.

cc @nt1m, @andruud

nt1m commented 2 months ago

Seems fine if it's spec compliant, cc @anttijk to check whenever he has time.

andruud commented 1 month ago

Looks good to me. (Blink passes the new test, but this looks good regardless of that).

BorisChiou commented 1 month ago

Thanks for the positive feedback. I'd land my patch soon.

BorisChiou commented 1 month ago

The PR: https://github.com/web-platform-tests/wpt/pull/46409

BorisChiou commented 1 month ago

It has been merged, so I close this issue.