web-platform-tests / interop

web-platform-tests Interop project
273 stars 28 forks source link

Add a @starting-style subtest for after-change style inheritance across ancestors #664

Closed lilles closed 1 month ago

lilles commented 1 month ago

There is a subtest for @starting-style that tests that transitions are based on the after-change style, which is supposed to not include animation effects when inheriting from the parent:

https://wpt.fyi/results/css/css-transitions/starting-style-cascade.html?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2024-starting-style%20or%20label%3Ainterop-2024-transition-behavior

Firefox is the only browser that implements this correctly, but Safari passes because they inherit correctly if the animating element is a direct parent in the case of @starting-style.

I would like to either get better coverage by adding a subtest (see CL below), or remove the current subtest from interop. Firefox passes this new tests while Chrome and Safari fails.

https://chromium-review.googlesource.com/c/chromium/src/+/5577020

@emilio @nt1m @josepharhar

emilio commented 1 month ago

Sgtm, cc @BorisChiou

BorisChiou commented 1 month ago

The subtest looks good to me.

foolip commented 1 month ago

@gsnedders @nt1m @stubbornella can you take a look at this for WebKit?

nt1m commented 1 month ago

Seems fine! Sorry for the delay, I was out for the last two weeks.

foolip commented 1 month ago

Thanks for review everyone. Closing this, @lilles please go ahead and make the change.

lilles commented 1 month ago

https://github.com/web-platform-tests/wpt/pull/46688