search

web-platform-tests / interop

web-platform-tests Interop project
https://wpt.fyi/interop
296 stars 28 forks source link

Add more dir-slots and dir-auto-dynamic tests to interop-dir #668

Closed vinhill closed 2 months ago

vinhill commented 4 months ago

Test List

Rationale

I'm working on the Firefox interop-dir failures and found a couple of untested cases that I would like to include in wpt. The changes are under review here.

I think it makes sense to include these tests in the test files mentioned above, but that would mean they would become part of interop. Is this okay for the other implementers?

In 'dir-slots-directionality', the added test cases merely assert behavior that I found odd. I will file a spec issue about these to clarify whether the behavior is intended.

In 'dir-auto-dynamic-changes', the added tests are

I am unable to test on Safari, but Chrome 127.0.6510.4 fails

dbaron commented 4 months ago

I think this seems fine. It's possible I'll find issues with the tests later, but we can always fix them later. (It will be easier to debug them once they're landed in WPT, so I'm inclined to just wait for them to land and then figure out why Chrome is failing those two tests.)

nt1m commented 3 months ago

This seems fine.

foolip commented 2 months ago

This had the required support and the change has already landed through https://github.com/web-platform-tests/wpt/pull/47069.