Test change proposal: remove at-property-shadow.html

web-platform-tests / interop

web-platform-tests Interop project

https://wpt.fyi/interop

280 stars 28 forks source link

Test change proposal: remove at-property-shadow.html #673

Closed emilio closed 1 month ago

emilio commented 2 months ago

Test List

https://wpt.fyi/results/css/css-properties-values-api/at-property-shadow.html?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2023-property

Rationale

Everybody fails it. Not convinced spec is correct, see https://github.com/w3c/css-houdini-drafts/pull/1085#issuecomment-1991302473

emilio commented 2 months ago

cc @andruud @nt1m

nt1m commented 2 months ago

Would be better if we can fix it, but open to removing if we can't.

andruud commented 1 month ago

(I was OOO for a bit).

Yes, please go ahead and remove it.

We have interop already for the old spec. This test represents a change that came in later. So it's a fairly "clean" removal.
As pointed out in https://github.com/w3c/css-houdini-drafts/pull/1085#issuecomment-1991302473, the spec isn't clear enough, and is possibly not sufficiently backed by actual resolutions.
Also, I vaguely remember @astearns concluding (at some point during CSS Day) that we might want to go back and reconsider how it should work in the first place.

Under the above circumstances, I probably would have objected to including the test in the first place.

astearns commented 1 month ago

It’s a good test to have, we just might need to change the expected result (as I did to match the current spec).

I’d prefer to keep the test, open an issue on the spec, then change the test if we decide to make changes to the spec.

jgraham commented 1 month ago

Note that the proposal is to remove the test from the interop set, not to actually delete it.

FWIW I think if the outcome here is spec changes that lead to everyone agreeing the test is correct as-is, and therefore continuing to pass it, I doubt there'd be many objections to re-adding the test to Interop.