search

web-platform-tests / pulls.web-platform-tests.org

[Deprecated] Some functionalities are now provided by wpt-pr-bot https://github.com/web-platform-tests/wpt-pr-bot
7 stars 23 forks source link

Fix multi comment #20

Closed bobholt closed 7 years ago

bobholt commented 7 years ago

This attempts to stop the bot from commenting multiple times on a single PR - possibly due to a race condition. It stores the comment URL to re-use in the database.

Tested on https://github.com/bobholt/web-platform-tests/pull/23. It is commenting and editing the single comment. Note that PR did not have an issue with multiple comments before. We'll just have to see if this works, but it's a more sensible solution than querying GitHub for all issue comments in any case.

Note: this includes commits from https://github.com/w3c/wptdash/pull/19, which should be reviewed and landed prior to this (but this shows you where it's all leading to).

This change is Reviewable

jgraham commented 7 years ago

Reviewed 2 of 2 files at r2, 1 of 1 files at r3, 4 of 4 files at r4. Review status: 7 of 13 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable