search

web-platform-tests / pulls.web-platform-tests.org

[Deprecated] Some functionalities are now provided by wpt-pr-bot https://github.com/web-platform-tests/wpt-pr-bot
7 stars 23 forks source link

Job number should be string instead of float #22

Closed Hexcles closed 7 years ago

Hexcles commented 7 years ago

In the models, Job has a number field with type db.Float: https://github.com/w3c/wptdash/blob/80e1c395bfc93c3712c91680f8c8ecee7ee90ba6/wptdash/models.py#L206

This causes trailing zeros of the number to be trimmed, among other potential problems. For example, Job 17762.10 becomes 17762.1 (https://pulls.web-platform-tests.org/build/17762).

We should really use db.String for this field.

Perhaps existing records in DB also need to be examined/refreshed after this bug is fixed.

Hexcles commented 7 years ago

@bobholt

bobholt commented 7 years ago

@Hexcles: I'm working on this today. I have the db migration stuff ready, but I'm trying to come up with a safe SQL script to safe convert the correct *.1s to *.10s

bobholt commented 7 years ago

@Hexcles: PR #24 opened for this.

bobholt commented 7 years ago

@Hexcles This has been deployed to production, and historical data should have been fixed. See https://pulls.web-platform-tests.org/build/18152 as an example (from 2017-09-04 and now shows 18152.10 as Job Number for Chrome Unstable)

Hexcles commented 7 years ago

@bobholt Awesome! Thanks!