search

web-platform-tests / pulls.web-platform-tests.org

[Deprecated] Some functionalities are now provided by wpt-pr-bot https://github.com/web-platform-tests/wpt-pr-bot
7 stars 23 forks source link

Ignore .DS_Store files (Mac Finder) #36

Closed lukebjerring closed 6 years ago

lukebjerring commented 6 years ago

This change is Reviewable

gsnedders commented 6 years ago

FWIW, I'd strongly recommend all macOS users putting https://github.com/github/gitignore/blob/master/Global/macOS.gitignore at $HOME/.config/git/ignore to ignore macOS files globally.

bobholt commented 6 years ago

I agree with @gsnedders and almost said as much on @AutomatedTester's PR in wptdashboard.

That said, I'm fine adding it to the local gitignore because on a broad public project like this, I don't expect all future contributors will have set up a global or that we'd want to tell each of them to do that every time this comes up.

AutomatedTester commented 6 years ago

While I agree, I feel this is a flaw in git that people have to manually handle this.

gsnedders commented 6 years ago

@bobholt Yeah, I've no strong objection to putting super-common things like .DS_Store in per-project .gitignore files, given we see such files get committed often enough.