search

web-platform-tests / results-collection

Other
41 stars 46 forks source link

Send browser_channel as a label to results receiver #572

Closed Hexcles closed 6 years ago

Hexcles commented 6 years ago

From https://github.com/web-platform-tests/wpt.fyi/issues/245

        response = requests.post(
            url,
            auth=(user_name, secret),
            data={'labels': browser_channel},
            files={'result_file': open(filename, 'rb')}
        )

Note: labels is a comma-separated string. Runners may add arbitrary labels and the wpt.fyi APIs can filter by labels.

cc @lukebjerring

lukebjerring commented 6 years ago

Shouldn't labels be an array of strings? That would make it more consistent with the golang struct and json marshalling behavior.

Hexcles commented 6 years ago

@lukebjerring this is a HTML form not JSON, which doesn't really have arrays. It's more like the repeatable params we use in URLs.