search

web-platform-tests / rfcs

web-platform-tests RFCs
75 stars 63 forks source link

Add RFC 111 for polyfill testing. #111

Closed flackr closed 2 years ago

jgraham commented 2 years ago

Based on the matrix discussion, I think this is a reasonable thing to land and injecting an inline script is probably the best approach for now. I hope we can update the RFC with some of the context we discussed on matrix about the various tradeoffs, observability of the injection, etc. so that it's clear to other readers why this is the right design choice.

flackr commented 2 years ago

RFC is updated, let me know if there's anything else you'd like to see here. I also added a short conclusion to explain the decision and rationale.

flackr commented 2 years ago

FYI, I don't have write access to be able to merge this.

jgraham commented 2 years ago

I would ideally like to see some approval from other members of the @web-platform-tests/wpt-core-team The last update was not yet a week ago, so per the process we do need to allow a little additional time for review.

flackr commented 2 years ago

Ack, thanks! Apologies I'm not familiar with the process here.

zcorpan commented 2 years ago

Please move the conclusion and the winning proposal into the "Details" section, and have the other alternative solutions in an "Alternatives considered" section.

I think there are some details missing. Which responses will get the rewrite? How do you opt in? Where is the script injected? Is the injection a classic script or a module script? (Module scripts have defer semantics by default, and tests may complete before deferred scripts are run.)

flackr commented 2 years ago

Thanks for taking a look!

Please move the conclusion and the winning proposal into the "Details" section, and have the other alternative solutions in an "Alternatives considered" section.

Done.

I think there are some details missing. Which responses will get the rewrite? How do you opt in? Where is the script injected? Is the injection a classic script or a module script? (Module scripts have defer semantics by default, and tests may complete before deferred scripts are run.)

I've now covered all of these in the details section. Let me know if there's anything else you'd like to see.

foolip commented 2 years ago

Alright, let's consider this RFC accepted, merging!

foolip commented 2 years ago

The next step will be review of https://github.com/web-platform-tests/wpt/pull/33338, which implements this RFC.