search

web-platform-tests / rfcs

web-platform-tests RFCs
74 stars 63 forks source link

Add an RFC for `add_top_level_completion_handler` #168

Open gsnedders opened 8 months ago

gsnedders commented 8 months ago

Rendered

gsnedders commented 8 months ago

In the case of no substantive disagreement the RFC is considered accepted after 1 week.

…and we've had no substantive disagreement in two weeks, so I guess that means this is accepted despite nobody having reviewed it? 🤨

gsnedders commented 4 months ago

see https://github.com/web-platform-tests/wpt-notes/blob/47c3ea1a941c0b0f78869ff2d00a2e2f93594636/minutes/2023-11-07.md#add-an-rfc-for-add_top_level_completion_handler for prior discussion in meeting

jcscottiii commented 4 months ago

This was discussed during the November 2023 meeting:

https://github.com/web-platform-tests/wpt-notes/blob/47c3ea1a941c0b0f78869ff2d00a2e2f93594636/minutes/2023-11-07.md#add-an-rfc-for-add_top_level_completion_handler

This RFC may need some updates

jgraham commented 4 months ago

Per the discussion in https://github.com/web-platform-tests/wpt-notes/blob/47c3ea1a941c0b0f78869ff2d00a2e2f93594636/minutes/2023-11-07.md?plain=1#L24 we might want to try a different implementation approach. We likely need to try with existing tests to see which approach is most robust.