search

web-platform-tests / rfcs

web-platform-tests RFCs
74 stars 63 forks source link

RFC 179: Remove support for Internet Explorer and Microsoft Edge Legacy #179

Closed mwjacksonmsft closed 5 months ago

mwjacksonmsft commented 5 months ago

Remove support for running WPT tests in Internet Explorer and Microsoft Edge Legacy.

gsnedders commented 5 months ago

cc @jimevans

IIRC, IEDriver is still used for IE Mode in Edge, which is still supported. We probably want some way to still test IEDriver?

Edge Legacy is probably a smaller deal here, and probably has code-rotted and is probably of little interest now.

mwjacksonmsft commented 5 months ago

@Ms2ger - The proposal is to just clean up and remove unsupported Microsoft browsers. I've put together a draft PR (https://github.com/web-platform-tests/wpt/pull/44233) that shows the remove of the Microsoft Edge Legacy browser.

mwjacksonmsft commented 5 months ago

@gsnedders I don't believe IEDriver uses anything from WPT tests to set up and use. I also don't believe that you can currently run WPT tests in IEMode via wpt run. If we wanted to add support, then I'd suggest we'd want the product name to be 'edge-iemode' (or similar) to avoid confusion with the IE-app.

foolip commented 5 months ago

One week has passed and there's no substantive disagreement, so I'll go ahead and merge this.

If it turns out that some of this code is still used by someone, then of course I think we should revisit.

foolip commented 4 months ago

The removals have happened in https://github.com/web-platform-tests/wpt/pull/44233 + https://github.com/web-platform-tests/wpt/pull/44344.

Thanks @mwjacksonmsft for cleaning this up! As I said, I hope that after some months we can rename the current Edge to just "edge" so it's more intuitive for users of ./wpt run.