search

web-platform-tests / rfcs

web-platform-tests RFCs
83 stars 67 forks source link

Always use the working copy for the manifest #19

Closed gsnedders closed 5 years ago

gsnedders commented 5 years ago

Rendered

(so GitHub picks it up: references https://github.com/web-platform-tests/wpt/issues/7206)

jgraham commented 5 years ago

This lgtm.

Can't we conspire to add the CSS build output to the ignore rules in the root?

gsnedders commented 5 years ago

Can't we conspire to add the CSS build output to the ignore rules in the root?

I don't think there's any stopping us from merging all the non-root non-third-party .gitignore files, but it still won't behave as git does (as it won't obey .git/info/excludes or core.excludesFile, nor will we handle tracked files correctly), which still isn't ideal.

It's also potentially surprising in the case of Chromium or Servo where it won't obey top-level .gitignore files (of course, in mozilla-central it's even harder, given we'd need some way to process .hgignore).

Hexcles commented 5 years ago

FWIW, Chromium always uses --work: https://cs.chromium.org/chromium/src/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py?l=209&rcl=b7338025b4a704fc08ee2348083fadfac4449a5e

The difference in default behaviours has caused some confusion when Chromium engineers occasionally use the upstream ./wpt toolchain.

gsnedders commented 5 years ago

No substantive disagreement, so considered accepted after 1 week