search

web-platform-tests / rfcs

web-platform-tests RFCs
74 stars 63 forks source link

RFC 198: Move the container image from Docker Hub to GitHub Registry #198

Closed OrKoN closed 1 week ago

OrKoN commented 1 month ago

This RFC proposes moving the container image from Docker Hub to GitHub Registry.

Issue https://github.com/web-platform-tests/wpt/issues/28903

Preview

OrKoN commented 3 weeks ago

@jcscottiii thanks for the feedback, I have included this into RFC. Note that someone with an admin permissions should configure the desired permissions (I have no access) and I can only add CODEOWNERS to my PR.

OrKoN commented 3 weeks ago
Screenshot 2024-06-04 at 20 03 58

The admins team does not seem to be suitable for CODEOWNERS. Perhaps it does not have write access?

foolip commented 3 weeks ago
Screenshot 2024-06-04 at 20 03 58

The admins team does not seem to be suitable for CODEOWNERS. Perhaps it does not have write access?

Yeah, everyone in the admin team is made an org owner, so we never give the team itself write access to anything. I've given the team write access to the wpt repo now, can you try again?

OrKoN commented 2 weeks ago

@foolip I have updated my PR, and it works now. The admins can be specified in CODEOWNERS.

OrKoN commented 2 weeks ago

Shall we land this RFC? (I have no permission to merge, so if anyone could hit the merge button it would be great)

jgraham commented 2 weeks ago

I think technically we need to wait another day.

OrKoN commented 1 week ago

@foolip @jgraham @jcscottiii it looks like a bit more than 2 weeks already passed and there are not unresolved concerns. Therefore, if someone could merge the PR, it would be great.