RFC: Remove support for stub-* files in the manifest

web-platform-tests / rfcs

web-platform-tests RFCs

75 stars 63 forks source link

RFC: Remove support for stub-* files in the manifest #27

Closed foolip closed 4 years ago

foolip commented 4 years ago

Rendered

foolip commented 4 years ago

https://github.com/web-platform-tests/wpt/pull/18744 shows all the code that would be removed, but I intend to split it into two changes as per the RFC.

jgraham commented 4 years ago

Sounds great. This idea didn't work out so I'm happy to remove support.

foolip commented 4 years ago

Draft PRs:

Paging SW reviewers @asutherland @mkruisselbrink @mattto @wanderview, are you all OK with this cleanup?

mfalken commented 4 years ago

Yes, as far as I know we never ran the stubs for Chromium and I never heard of anyone working on them.

foolip commented 4 years ago

Thanks @mattto, I'll take that as support for https://github.com/web-platform-tests/wpt/pull/18745. Since @jgraham has already reviewed that and it's cleanup that by itself wouldn't go through the RFC process, I'll merge that now. It'll be good to put some time between that and the manifest change.

foolip commented 4 years ago

Alright, I consider this passed, I'll merge it and finish https://github.com/web-platform-tests/wpt/pull/18746.

foolip commented 4 years ago

https://github.com/web-platform-tests/wpt/pull/18746 has also been merged now, so this is done. Thanks all!