search

web-platform-tests / rfcs

web-platform-tests RFCs
75 stars 63 forks source link

RFC 44: testing origin policy #44

Closed domenic closed 4 years ago

domenic commented 4 years ago

Rendered

zcorpan commented 4 years ago

This looks good to me, but is there a downside to using a greater number of subdomains from the start (like 99)? I'm thinking that there may be some churn to changing the subdomains, so it's better to do it fewer times and end up with more subdomains than we need, than to change them multiple times.

domenic commented 4 years ago

Yeah, I think you're right; that'd probably be a better place to start. I will update the RFC and pull request.

jgraham commented 4 years ago

Is there a requirement that each test uses a different origin? Do we have some way to enforce/lint for that?

domenic commented 4 years ago

No, it's not. As long as the tests are careful to test non-overlapping features, they can share. You can see some examples of that in https://github.com/web-platform-tests/wpt/pull/21739 (which was for some reason closed....)

jgraham commented 4 years ago

Hmm, having to be careful about testing non-overlapping features makes me nervous about conflicts between apparently unrelated tests (e.g. if two authors write tests at the same time for the same feature). However given that we can't make a wildcard certificate I don't currently have any good ideas for improvements here.

domenic commented 4 years ago

OK, cool! It looks like it's been 7 days; would we be able to merge this---and more importantly, https://github.com/web-platform-tests/wpt/pull/21705 --- now?

gsnedders commented 4 years ago

Note we previously had problems on Windows where IIRC we end up with all the hosts in an environment variable and this might take us over the maximum length of a variable.

domenic commented 4 years ago

@gsnedders yes, that was dealt with in https://github.com/web-platform-tests/wpt/pull/21705#issuecomment-587578635