search

web-platform-tests / rfcs

web-platform-tests RFCs
75 stars 63 forks source link

RFC #48: Split 'assert_precondition' into optional and non-optional variants #48

Closed stephenmcgruer closed 4 years ago

stephenmcgruer commented 4 years ago

See https://github.com/web-platform-tests/wpt/issues/21971 for background information

Hexcles commented 4 years ago

Nit: I think we want to match the RFC number with the PR number, i.e. 48 for this one.

stephenmcgruer commented 4 years ago

Nit: I think we want to match the RFC number with the PR number, i.e. 48 for this one.

Oh is that how that works? (I could not figure out how the RFC numbers were chosen other than incrementing.) We should document that. Which will require a PR. Which will cause RFCs to be skipped. Hrm.

jgraham commented 4 years ago

Skipping numbers isn't a problem, we won't run out ;) The point is not to know the order of RFCs being submitted, or have a simple mechanism to count RFCs, but to have a simple relationship between the RFC document and the associated discussion.

Hexcles commented 4 years ago

PR numbers are not consecutive anyways because of issues.

stephenmcgruer commented 4 years ago

Both very good points :). I'll send out a PR to document this, and update the text here.

stephenmcgruer commented 4 years ago

I'll send out a PR to document this

SHS0t0ATMRs

Sigh. I'll be over here, in the corner with people who don't read the README properly -_-

stephenmcgruer commented 4 years ago

With two approvals and no dissenting comments in the last 7 days, I am merging this per the RFC process.