web-platform-tests / rfcs

web-platform-tests RFCs
75 stars 63 forks source link

RFC 71: Support adding URI fragments for reftests #71

Closed lilles closed 1 year ago

stephenmcgruer commented 3 years ago

@jgraham and I discussed this RFC today (apologies for the delay). We agree that the multiple variants problem needs some thought; both of us have committed to think about it and get back to this issue. Please ping me if there isn't an update by next week :)

lilles commented 3 years ago

Thanks for the update

lilles commented 3 years ago

@jgraham and I discussed this RFC today (apologies for the delay). We agree that the multiple variants problem needs some thought; both of us have committed to think about it and get back to this issue. Please ping me if there isn't an update by next week :)

Ping?

zcorpan commented 2 years ago

I had forgotten that variant doesn't work for reftests, and tried to use it in https://github.com/web-platform-tests/wpt/pull/30267/commits/5c13141d5062c187c0cd38cddeb4f719d2fa4052

In this case the ref is the same for all variants.

gsnedders commented 1 year ago

@mrego said in https://github.com/web-platform-tests/wpt/issues/26364#issuecomment-932161355:

It seems it's possible to write tests for ::target-text with location.href (see https://github.com/web-platform-tests/wpt/blob/master/css/css-highlight-api/painting/custom-highlight-painting-below-target-text.html).

So I guess one question is whether we still have any need for this feature?

lilles commented 1 year ago

It should no longer be necessary for my original use case, at least.

foolip commented 1 year ago

Let's go ahead and close this since the original motivation is no longer there. If someone else wants to drive it, feel free to clone into a new RFC to resolve the remaining issues.