search

web-platform-tests / rfcs

web-platform-tests RFCs
75 stars 63 forks source link

RFC 72: Address space overrides. #72

Closed letitz closed 3 years ago

letitz commented 3 years ago

Addresses issue web-platform-tests/wpt#26166.

cc @mikewest @camillelamy @hemeryar

stephenmcgruer commented 3 years ago

To keep this RFC up-to-date, at this point I believe WPT's stance* is that this should be done via browser flags rather than have the testrunner (or some setup done by the testrunner) have system privileges. Both Blink and Gecko infra have said that having privileges in this way is at least not commonly done (but not explicitly banned).

We would like to see the aforementioned issues against browsers opened and discussions occur there (please link to them in this discussion). If a reasonable number of browsers think the level of support is unacceptably high, we can revisit the system-privilege angle.

* Based on discussion between @jgraham and myself today, plus previous comments from @Hexcles

letitz commented 3 years ago

I will open issues against other browsers to seek their input. Thanks for the discussion so far!

letitz commented 3 years ago

Filed bug 1681316 against Firefox. Any help locating appropriate contacts within Mozilla to assign the bug to or cc on the bug is appreciated!

letitz commented 3 years ago

Filed bug 219642 against WebKit.

letitz commented 3 years ago

Thanks @jgraham for helping triage the Firefox bug. Does anyone on this thread have a contact at WebKit I could ask to get some traction on that bug?

jgraham commented 3 years ago

@gsnedders perhaps

letitz commented 3 years ago

Thanks!

letitz commented 3 years ago

@stephenmcgruer I believe we have consent from Gecko (see @ddragana's comment above) and WebKit (see bug 219642).

OK with you to proceed?

stephenmcgruer commented 3 years ago

OK with you to proceed?

Unfortunately I'm no longer working on WPT matters, so I don't want to say yes when the consequences are on others. Instead, passing this to foolip@ and jgraham@ to sign off. For the record, I think this should be good to go based on https://github.com/web-platform-tests/rfcs/pull/72#issuecomment-737487271 and the subsequent work letitz has done.

letitz commented 3 years ago

Thanks for the redirect! @jgraham @foolip WDYT?

letitz commented 3 years ago

Thanks for the reviews! I'm not familiar with this workflow: how does this PR get merged now?

foolip commented 3 years ago

As a newly returning member of the wpt core team there's a risk of embarrassing myself here, but per https://github.com/web-platform-tests/rfcs#the-rfc-process the latest "new information" would be your ping in https://github.com/web-platform-tests/rfcs/pull/72#issuecomment-805719591 and we can consider this accepted if there's no further feedback by March 31.

letitz commented 3 years ago

Oh, I believed the previous discussion and your approvals were enough. It seems to me all stakeholders have had ample time to review this since November. Anyway, I won't haggle for 2 days after 5 months of waiting. Glad this is finally getting merged :)

foolip commented 3 years ago

@letitz I'm only unsure about the status of WebKit and wanted to be sure @gsnedders had the full 7 days after this became ready to go. https://bugs.webkit.org/show_bug.cgi?id=219642 doesn't load for me right now, but if the discussion has already happened there, then really we could go ahead.

Please feel free to prepare an implementation PR in the meantime.

foolip commented 3 years ago

Alright, two more days have passed, I'm merging this now.