search

web-platform-tests / rfcs

web-platform-tests RFCs
75 stars 63 forks source link

Allow unrestricted Promise usage in testharness.js #93

Closed jgraham closed 2 years ago

annevk commented 2 years ago

I was hoping for a policy that would have this as a side effect, but perhaps it's good to decide on this individually as well.

jgraham commented 2 years ago

Yes, #92 is about overall policy, but this seems like low hanging fruit so worth splitting out into a smaller item.

https://github.com/web-platform-tests/wpt/pull/29985 is a PR with the actual code changes to remove the support for testing testharness without the Promise constructor.

Ms2ger commented 2 years ago

Ping @louaybassbouss about the WAVE comment in particular

louaybassbouss commented 2 years ago

Ping @louaybassbouss about the WAVE comment in particular

Thanks @Ms2ger for pinging me let me check I will ASAP to you.

jgraham commented 2 years ago

@louaybassbouss do you have an update here, or can we go ahead and merge this?

FritzHeiden commented 2 years ago

@louaybassbouss do you have an update here, or can we go ahead and merge this?

Looks good, go ahead and merge

foolip commented 2 years ago

It looks like the test cleanup for this never happened, so actually adding dependencies on Promise is still hard. I've sent https://github.com/web-platform-tests/wpt/pull/33507.