search

web-platform-tests / wpt.fyi

web-platform-tests dashboard
https://wpt.fyi/
Other
183 stars 88 forks source link

Triage UI makes big changes that are hard to vet #1957

Open foolip opened 4 years ago

foolip commented 4 years ago

I wanted to link another bug today, which resulted in https://github.com/web-platform-tests/wpt-metadata/pull/217.

https://bugs.webkit.org/show_bug.cgi?id=143842 is the bug I linked, at the end of the diff, but there are lots of other changes that are very hard to check if they're correct or not.

If the API will normalize the files, perhaps it would be a good idea to enforce that same still in the repo so that diffs will be more reasonable.

KyleJu commented 4 years ago

We will normalize the flies in a sorting order and do it occasionally

stephenmcgruer commented 3 years ago

Note: I did a manual cleanup pass here that I think was a positive step: https://github.com/web-platform-tests/wpt-metadata/pull/803

One interesting discovery - from yaml v2 to yaml v3 the format of the written out yaml files changed significantly. So if that continues to happen we will end up conflicting with past selves when we update dependencies in wpt.fyi! >_<