search

web-platform-tests / wpt.fyi

web-platform-tests dashboard
https://wpt.fyi/
Other
183 stars 88 forks source link

Different number of subtests at top and bottom of results table #3834

Open foolip opened 3 months ago

foolip commented 3 months ago

Looking at https://wpt.fyi/results/compat?run_id=5095555055484928&run_id=5174632751824896&run_id=5155156954185728&run_id=5128162447196160 I see "Showing 31 tests (98 subtests)" at the top of the table, but the Subtest Total at the bottom has numbers like 109 / 119, suggesting 119 subtests.

I would expect these numbers to match. (And when using view=test I'd expect the test counts to match instead.)

jcscottiii commented 3 months ago

@foolip For view=test, we can add a conditional to remove the (X subtests) clause if it is the test view. But in test=view the test count (while ignoring the subtest count) is correct.

For the default subtest view, I'm not sure what's going on though for the slightly off error. @DanielRyanSmith, this logic comes from computeResultsTotalsRangeMessage. If not, I can do some deeper looking later this week.

DanielRyanSmith commented 3 months ago

I will be OOO for a few weeks coming up, and I don't think I'll be able to look into this beforehand. Sorry I couldn't be of more help, but I can still assist when I'm back if need be. 🙂

foolip commented 3 months ago

That's OK, this isn't urgent, it's probably been like this for years. Have good time off, @DanielRyanSmith!