search

web-platform-tests / wpt.fyi

web-platform-tests dashboard
https://wpt.fyi/
Other
182 stars 88 forks source link

Add experimental interop mobile results view #3959

Open DanielRyanSmith opened 2 weeks ago

DanielRyanSmith commented 2 weeks ago

This change pulls mobile results data from the interop-results repo and uses it to display a new mobile results view on the Interop dashboard. Currently, there is no navigable link displayed on the site, but the page can be accessed by adding the mobileView query string param to the interop 2024 page.

Screenshot 2024-08-25 at 5 52 24 PM

DanielRyanSmith commented 2 weeks ago

It looks like the linter is failing due to an issue unrelated to this change.

api/query/cache/index/index.go:210:18: G115: integer overflow conversion uint64 -> int (gosec)
        shardIdx := int(t.testID % numShardsU64)
                       ^
api/query/cache/backfill/backfill.go:120:14: G115: integer overflow conversion uint64 -> int (gosec)
    limit := int(maxBytes/bytesPerRun) / len(shared.GetDefaultProducts())

https://github.com/securego/gosec/pull/1149

KyleJu commented 2 weeks ago

It looks like the linter is failing due to an issue unrelated to this change.

api/query/cache/index/index.go:210:18: G115: integer overflow conversion uint64 -> int (gosec)
      shardIdx := int(t.testID % numShardsU64)
                     ^
api/query/cache/backfill/backfill.go:120:14: G115: integer overflow conversion uint64 -> int (gosec)
  limit := int(maxBytes/bytesPerRun) / len(shared.GetDefaultProducts())

securego/gosec#1149

I will get to it shortly

KyleJu commented 2 weeks ago

It looks like the linter is failing due to an issue unrelated to this change.

api/query/cache/index/index.go:210:18: G115: integer overflow conversion uint64 -> int (gosec)
        shardIdx := int(t.testID % numShardsU64)
                       ^
api/query/cache/backfill/backfill.go:120:14: G115: integer overflow conversion uint64 -> int (gosec)
    limit := int(maxBytes/bytesPerRun) / len(shared.GetDefaultProducts())

securego/gosec#1149

I will get to it shortly

Sent out https://github.com/web-platform-tests/wpt.fyi/pull/3968

DanielRyanSmith commented 2 weeks ago

View the staging deployment here: https://2024-08-25-mobile-resu-dot-wptdashboard-staging.uk.r.appspot.com/interop-2024?mobileView

It might be worth changing this view in some way to be even more explicit that these are mobile results and experimental results.

jgraham commented 4 days ago

I don't have detailed code-level feedback, but: