search

web-platform-tests / wpt.live

A live version of the web-platform-tests project
https://wpt.live/
15 stars 11 forks source link

Publish previews to top-level directory #23

Closed jugglinmike closed 4 years ago

jugglinmike commented 4 years ago

Move previews from the submissions/ directory to the server root and operate on git refs whose names are integers (in other words, remove the "gh-" prefix).

@foolip I'm a bit wary to use unadorned integers as identifiers. That could be confusing in some contexts. The system would seem more coherent to me if it qualified these in some way, such as GitHub's own "gh-" prefix. In the interest of consistency, that'd show up in the URLs as well, but I wonder if you feel http://wptpr.live/gh-1234 is overly long or redundant.

foolip commented 4 years ago

I don’t think there will ever be a spec which is just numbers, so I’d prefer the bare numbers. The gh-prefix convention is one I’ve only really seen you use. @Hexcles for opinions / to break the tie.

jugglinmike commented 4 years ago

Agreed, collision avoidance is definitely not a motivation for using qualified identifiers.

jugglinmike commented 4 years ago

Oh, and this resolves gh-22

Hexcles commented 4 years ago

I think as long as these only show up in the wptpr.live domain, we don't need the gh- prefix. "PR" provides enough context already.

jugglinmike commented 4 years ago

Alrighty then