search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
5.01k stars 3.11k forks source link

Move server substitutions to allow-listing config variables #10097

Open gsnedders opened 6 years ago

gsnedders commented 6 years ago

Currently the server-side substitutions expose the entire config; we should just whitelist those that make any sense to reference mostly so we don't need to worry about accidentally breaking tests when changing the config (and hopefully make it harder to forget to update it).

foolip commented 6 years ago

This came up in triage today because of priority:roadmap. @gsnedders, has it ever happened that we wanted to rename something that a test depended on that still doesn't make sense to reference? That'll break the test, isn't that OK if it didn't make sense?

gsnedders commented 6 years ago

I don't think so?

foolip commented 6 years ago

I probably don't quite understand the issue, but switching to priority:backlog to signal my ignorance :)

gsnedders commented 6 years ago

Basically it's avoiding the risk, and it's a small amount of work.

gsnedders commented 5 years ago

https://gist.github.com/51fb72a7ee92ce9da4e7f3768273a772 is everything matching {{[^}]*}} in WPT.

So:

appear to be all that's used from the config?