search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
4.88k stars 3.05k forks source link

/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-after-controls-added.html is disabled/disabled in mozilla chromium #11066

Open zcorpan opened 6 years ago

zcorpan commented 6 years ago

http://bocoup.github.io/wpt-disabled-tests-report/

Investigate what's up with this test:

Path Products Results Bugs
/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-after-controls-added.html mozilla chromium disabled [ Skip ] https://bugzilla.mozilla.org/show_bug.cgi?id=1433462 https://crbug.com/832157

Maybe the ref needs to do a few rAF before takeScreenshot.

foolip commented 6 years ago

This test came from https://github.com/w3c/web-platform-tests/commit/506cf5bac9c79c03ae489e0b7a63580670e3ed54. @srirama179 @fsoder, any ideas?

There's already a lot of rAF here. Would be interesting to look at a failing case.

foolip commented 6 years ago

It's linked to https://crbug.com/832157 in TestExpectations, so also poking @rebeccahughes and @mounirlamouri

srirama179 commented 6 years ago

After changing the controls state, there is one rAF just before taking screenshot. Probably adding one more rAF should work fine though. If i remember correctly it was passing locally when i run 1000 times. I will try to reproduce the issue locally again with latest build.

zcorpan commented 6 years ago

I mean rAF in the reference, not more in the test.

foolip commented 6 years ago

Ah, I see.

mounirlamouri commented 6 years ago

It's related to https://crbug.com/832157. It may be resolved if we run the wpt in "test mode" for the controls because it otherwise may be dependant on the timing of the animation.

fsoder commented 6 years ago

"Needs moar rAF (in the ref)" sounds like a good guess without having seen how it fails. (And since this is Skip, there no easily accessible data.)

srirama179 commented 6 years ago

I am able to simulate the issue. Looks like some recent changes would have changed the behaviour. Adding rAFs in ref test doesn't solve the issue but one thing for sure is that the issue is with ref test itself. Attaching the screenshot for your reference. I have tried loading the test and ref test directly in browser and i can see that incase of ref test the play button rotates for 2s during which the "Text" is greyed out. mediacontrols

srirama179 commented 6 years ago

Modern media controls are enabled in https://chromium-review.googlesource.com/c/chromium/src/+/922917. I disabled them in media_switches and the test case is passing. Ran the test locally with 1000 iterations and it is fine. With modern media controls, there is an overlap play button displayed which rotates for around 2s before which the text behind it is greyed out.