web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
4.99k stars 3.1k forks source link

Move browser discovery into wptrunner #12719

Open gsnedders opened 6 years ago

gsnedders commented 6 years ago

At the moment, we have a mixture of logic in tools/wpt/browser.py and tools/wptrunner/wptrunner/webdriver_server.py and tools/wptrunner/wptrunner/browser/*.py; we should simplify all this.

We have:

On the face of it, what we want in wpt is just the installation management side of things.

jgraham commented 6 years ago

I don't think wptrunner is doing anything complex; it just takes the binary you pass it through command line options and uses that. The only change is can make is wrapping it in a debugger if you are trying to run under gdb or similar. Is that not the case?

I changed the browser_version thing as part of #12679

That said I agree with the conceptual separation that wpt run should deal with setting up the environment, and wptrunner should use the provided environment.