Open gsnedders opened 6 years ago
I don't think wptrunner is doing anything complex; it just takes the binary you pass it through command line options and uses that. The only change is can make is wrapping it in a debugger if you are trying to run under gdb or similar. Is that not the case?
I changed the browser_version
thing as part of #12679
That said I agree with the conceptual separation that wpt run
should deal with setting up the environment, and wptrunner
should use the provided environment.
At the moment, we have a mixture of logic in tools/wpt/browser.py and tools/wptrunner/wptrunner/webdriver_server.py and tools/wptrunner/wptrunner/browser/*.py; we should simplify all this.
We have:
browser_version
passed in as akwarg
towptrunner.start
fromwpt.run
, but doesn't get passed in in any other way (everything else that ends up inkwargs
comes from the argument parser)On the face of it, what we want in
wpt
is just the installation management side of things.