search

web-platform-tests / wpt

Test suites for Web platform specs — including WHATWG, W3C, and others
https://web-platform-tests.org/
Other
5.01k stars 3.11k forks source link

Make test() calls after completion fail nicer #13766

Open gsnedders opened 6 years ago

gsnedders commented 6 years ago

13713 reported that a test was providing odd output:

Running, 18 complete, 0 remain

This is because it added more tests after completion. We should probably make adding tests after completion something that causes a harness ERROR, and probably output something informative to console.log (given I don't think we have anywhere else to output it?).

foolip commented 6 years ago

@jugglinmike for opinions. It seems to me there's only a very short window between tests finishing and the results being sent off that this could be turned into a harness error.

gsnedders commented 6 years ago

Oh, that's true. We should certainly do something better when we get a test start after completion, though, even if we don't mark it as an error.